Re: [Open-FCoE] [PATCH] libfc: fix handling of fc frame in fc_exch_recv_bls()

[Hillf Danton <dhillf@xxxxxxxxx>]

good comment and thanks //Hillf

On Tue, Oct 19, 2010 at 11:00 PM, Zou, Yi <yi.zou@xxxxxxxxx> wrote:
>>
>> There seems that fp should get freed if exch is unavailable.
>>
>> Signed-off-by: Hillf Danton <dhillf@xxxxxxxxx>
>> ---
>>
>> --- a/drivers/scsi/libfc/fc_exch.c  Â2010-09-13 07:07:38.000000000 +0800
>> +++ b/drivers/scsi/libfc/fc_exch.c  Â2010-10-19 21:35:08.000000000 +0800
>> @@ -1564,8 +1564,11 @@ static void fc_exch_recv_bls(struct fc_e
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â fc_frame_free(fp);
>> Â Â Â Â Â Â Â Â Â Â Â break;
>> Â Â Â Â Â Â Â case FC_RCTL_BA_ABTS:
>> - Â Â Â Â Â Â Â Â Â Â fc_exch_recv_abts(ep, fp);
>> - Â Â Â Â Â Â Â Â Â Â break;
>> + Â Â Â Â Â Â Â Â Â Â if (ep) {
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â fc_exch_recv_abts(ep, fp);
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â break;
>> + Â Â Â Â Â Â Â Â Â Â }
>> + Â Â Â Â Â Â Â Â Â Â /* fall thru */
>> Â Â Â Â Â Â Â default: Â Â Â Â Â Â Â Â Â Â Â Â/* ignore junk */
>> Â Â Â Â Â Â Â Â Â Â Â fc_frame_free(fp);
>> Â Â Â Â Â Â Â Â Â Â Â break;
>
> No, fc_exch_recv_abts() already checks ep at its very beginning and gets
> freed there.
>
> yi
>
ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±þÇ‹ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf