RE: [Open-FCoE] [PATCH] libfc: fix handling of fc frame in fc_exch_recv_bls()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> There seems that fp should get freed if exch is unavailable.
> 
> Signed-off-by: Hillf Danton <dhillf@xxxxxxxxx>
> ---
> 
> --- a/drivers/scsi/libfc/fc_exch.c	2010-09-13 07:07:38.000000000 +0800
> +++ b/drivers/scsi/libfc/fc_exch.c	2010-10-19 21:35:08.000000000 +0800
> @@ -1564,8 +1564,11 @@ static void fc_exch_recv_bls(struct fc_e
>  				fc_frame_free(fp);
>  			break;
>  		case FC_RCTL_BA_ABTS:
> -			fc_exch_recv_abts(ep, fp);
> -			break;
> +			if (ep) {
> +				fc_exch_recv_abts(ep, fp);
> +				break;
> +			}
> +			/* fall thru */
>  		default:			/* ignore junk */
>  			fc_frame_free(fp);
>  			break;

No, fc_exch_recv_abts() already checks ep at its very beginning and gets
freed there.

yi
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux