James: I'm still awaiting some feedback on this patch submission: http://marc.info/?l=linux-scsi&m=128387424521838&w=2 > This patch (as1415) improves the formerly incomprehensible logic in > sd_media_changed() (the current code refers to "changed" as a state, > whereas in fact it is a relation between two states). It also adds a > big comment so that everyone can understand what is really going on. > > The patch also improves efficiency by not reporting a media change > when no medium was ever present. If no medium was present the last > time we checked and there's still no medium, it's not necessary to > tell the caller that a change occurred. Doing so merely causes the > caller to attempt to revalidate a non-existent disk, which is a waste > of time. While not critically important, it does fix a bug: It gets rid of excess I/O (attempts to probe a drive with no medium currently generate two TEST UNIT READY commands, but only one is needed). Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
