On 10/1/10 5:18 AM, "Hannes Reinecke" <hare@xxxxxxx> wrote:
>
>
> This patch fixes a regression introduced by commit
> 083a469db4ecf3b286a96b5b722c37fc1affe0be
>
> qla2xxx_eh_wait_on_command() is waiting for an srb to
> complete, which will never happen as the routine took
> a reference to the srb previously and will only drop it
> after this function. So every command abort will fail.
>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
> Cc: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 1e4bff6..0af7549 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -883,6 +883,9 @@ qla2xxx_eh_abort(struct scsi_cmnd *cmd)
> }
> spin_unlock_irqrestore(&ha->hardware_lock, flags);
>
> + if (got_ref)
> + qla2x00_sp_compl(ha, sp);
> +
> /* Wait for the command to be returned. */
> if (wait) {
> if (qla2x00_eh_wait_on_command(cmd) != QLA_SUCCESS) {
> @@ -893,9 +896,6 @@ qla2xxx_eh_abort(struct scsi_cmnd *cmd)
> }
> }
>
> - if (got_ref)
> - qla2x00_sp_compl(ha, sp);
> -
> qla_printk(KERN_INFO, ha,
> "scsi(%ld:%d:%d): Abort command issued -- %d %lx %x.\n",
> vha->host_no, id, lun, wait, serial, ret);
void
qla2x00_sp_compl(struct qla_hw_data *ha, srb_t *sp)
{
if (atomic_read(&sp->ref_count) == 0) {
DEBUG2(qla_printk(KERN_WARNING, ha,
"SP reference-count to ZERO -- sp=%p\n", sp));
DEBUG2(BUG());
return;
}
if (!atomic_dec_and_test(&sp->ref_count))
return;
qla2x00_sp_final_compl(ha, sp);
}
All completions will check for reference count going to zero before
releasing the sp structure. Since the ref count is incremented by the
eh_abort hanlder, I don't see sp getting released unless ref count goes to
0. I could not see any other places where sp is getting released. Do you
have any stack trace or logs so that I can analyze more.
-- Giri
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
