On Mon, 2010-08-16 at 17:02 -0700, Karen Xie wrote: > Thanks, Joe. > > I will update the patch with your suggestion. BTW, I probably won't use > pr_<level> just to avoid any confusion since they are already defined in > kernel.h. I know I can undef them, but rather not to. Hi Karen. The point is to use pr_<level> precisely because it is defined in kernel.h and they are standard kernel functions commonly used in the rest of the kernel source. There's no need to undef it any more than there is to #undef printk or use a #define printf printk cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html