Thanks, Will use pr_xxx instead. Karen -----Original Message----- From: Joe Perches [mailto:joe@xxxxxxxxxxx] Sent: Thursday, August 12, 2010 8:22 PM To: Karen Xie Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; open-iscsi@xxxxxxxxxxxxxxxx; Rakesh Ranjan; James.Bottomley@xxxxxxxxxxxxxxxxxxxxx; michaelc@xxxxxxxxxxx Subject: Re: [PATCH v2 1/3] libcxgbi: common library for cxgb3i and cxgb4i On Thu, 2010-08-12 at 19:57 -0700, kxie@xxxxxxxxxxx wrote: > [PATCH v2 1/3] libcxgbi: common library for cxgb3i and cxgb4i [] > +#define libcxgbi_log_error cxgbi_dbg_error > +#define libcxgbi_log_warn cxgbi_dbg_warn > +#define libcxgbi_log_info cxgbi_dbg_info > +#define libcxgbi_log_debug(flag, fmt, args...) \ > + cxgbi_dbg_print(flag, fmt, ## args) I think this double indirection isn't useful and it would be simpler/better to use pr_<level> [] > +#define cxgbi_dbg_print(level, fmt, args...) \ > + do { \ > + if (dbg_level & (level)) \ > + printk(KERN_INFO "cxgbi: %s - " fmt, \ > + __func__ , ## args); \ > + } while (0) > +#define cxgbi_dbg_error(fmt, args...) \ > + printk(KERN_ERR "cxgbi: ERR! %s, " fmt, __func__ , ## args) > +#define cxgbi_dbg_warn(fmt, args...) \ > + printk(KERN_WARNING "cxgbi: WARN! %s, " fmt, __func__ , ## args) > +#define cxgbi_dbg_info(fmt, args...) \ > + printk(KERN_INFO "cxgbi: %s, " fmt, __func__ , ## args) ��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
