Re: scsi: convert discard to REQ_TYPE_FS instead of REQ_TYPE_BLOCK_PC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "Doug" == Douglas Gilbert <dgilbert@xxxxxxxxxxxx> writes:

>> Maximum Unmap LBA Count> 0 (in combination with the descriptor count)
>> are what indicate that the device server supports UNMAP.

Doug> That has been superseded by the TPU and TPWS bits in the Thin
Doug> provisioning VPD page (B2h) in sbc3r22.  TPU and TPWS indicate
Doug> support for the UNMAP and WRITE SAME (16) with UNMAP bit **
Doug> commands respectively.

*sigh* this is getting more and more convoluted.  I really wish T10 had
been able to agree on a single approach instead of 2.


Doug> I think sbc3r22 is just flaky in that area and will be cleaned up
Doug> soon. As the words stand now, in the Block limits VPD page
Doug> "maximum unmap lba count" only applies to the UNMAP command while
Doug> "optimal unmap granularity" applies to both the UNMAP command and
Doug> the WRITE SAME(16) command. Inconsistent.  And "maximum unmap lba
Doug> count"==0 implying no UNMAP command is pointless given the TPU
Doug> bit.

I'll ask around and see what the plans are in T10 when I get back from
vacation next week.  And I'll try to adjust our heuristics accordingly.

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux