On Fri, 02 Jul 2010 09:53:35 +0200 Jens Axboe <axboe@xxxxxxxxx> wrote: > On 2010-07-02 09:52, Christoph Hellwig wrote: > > On Fri, Jul 02, 2010 at 04:33:23PM +0900, FUJITA Tomonori wrote: > >> We could kill q->prepare_flush_fn(). Except for ide, all the users > >> just mark flush requests. They can use REQ_FLUSH flag instead. Ide can > >> do like SCSI. > > > > Yes, and I think you should go all the way to kill it instead of > > keeping both APIs around. Otherwise the patchset looks good to me. > > Fully agree, lets get rid of ->prepare_flush_fn(). Ok, I'll send patches to clean up all the users of prepare_flush_fn() soon. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
