scsi-ml builds flush requests via q->prepare_flush_fn(), however, builds discard requests via q->prep_rq_fn. Using two different mechnisms for the similar requests (building commands in SCSI ULD) doesn't make sense. Handing both via q->prep_rq_fn makes the code simpler. We could kill q->prepare_flush_fn(). Except for ide, all the users just mark flush requests. They can use REQ_FLUSH flag instead. Ide can do like SCSI. == block/blk-barrier.c | 12 ++++-------- drivers/scsi/sd.c | 26 ++++++++++++++++---------- include/linux/bio.h | 2 ++ 3 files changed, 22 insertions(+), 18 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
