>-----Original Message----- >From: Mike Christie [mailto:michaelc@xxxxxxxxxxx] >Sent: Wednesday, June 16, 2010 3:03 PM >To: Vikas Chaudhary >Cc: james.bottomley@xxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; Ravi Anand; Karen >Higgins >Subject: Re: [PATCH 07/11] qla4xxx: Added support for ISP82XX > >On 06/16/2010 03:54 PM, Vikas Chaudhary wrote: >> } else { >> DEBUG2(printk("scsi%ld: Unknown mailbox status %08X\n", >> ha->host_no, mbox_status)); >> >> - ha->mbox_status[0] = mbox_status; >> + ha->mbox_status[0] = mbox_sts[0]; >> } >> } > >Is this right? mbox_sts[0] is not set at this point, and you get: > >drivers/scsi/qla4xxx/ql4_isr.c: In function 'qla4xxx_isr_decode_mailbox': >drivers/scsi/qla4xxx/ql4_isr.c:634: warning: 'mbox_sts' may be used >uninitialized in this function > >We should not hit the case though, right. Maybe in a follow up patch you >can fix this since the rest of the patches look ok, and I do not want to >look a them ever again :) Thanks for pointing this out. You are right we will not hit this case. I will send follow up patch to fix this. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
