On 06/16/2010 03:54 PM, Vikas Chaudhary wrote:
} else {
DEBUG2(printk("scsi%ld: Unknown mailbox status %08X\n",
ha->host_no, mbox_status));
- ha->mbox_status[0] = mbox_status;
+ ha->mbox_status[0] = mbox_sts[0];
}
}
Is this right? mbox_sts[0] is not set at this point, and you get:
drivers/scsi/qla4xxx/ql4_isr.c: In function ‘qla4xxx_isr_decode_mailbox’:
drivers/scsi/qla4xxx/ql4_isr.c:634: warning: ‘mbox_sts’ may be used
uninitialized in this function
We should not hit the case though, right. Maybe in a follow up patch you
can fix this since the rest of the patches look ok, and I do not want to
look a them ever again :)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
