On Wed, 02 Jun 2010 10:55:17 -0400 Douglas Gilbert <dgilbert@xxxxxxxxxxxx> wrote: > Is it so important to have scsi_get_lba() for "PC" commands? > Why not just return 0 or MAX_UINT and be done with it. Might not be so important. However, as I wrote to Martin, we already have duplicated code that does the same thing. It's nice if we can clean them up. > A "PC" command might be lots of things. For example: > - a tunnelled ATA command > - a non SCSI protocol > - a SCSI vendor specific or obsolete command > (e.g. some SCSI PRINTER commands share opcodes with > READ and WRITE) > - from a lesser used command set (e.g. OSD or SSC) > > A LLD may well be able to narrow the field if it has a > reason to decode the command to find a LBA or other info. Yeah, but it would be better to set such info in the common place? If a LLD likes, it gets such info again in any way for itself. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
