Re: megaraid sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 26, 2010 at 02:28:02PM -0700, Randy Dunlap wrote:
> ping??
> > 		sprintf (adapter->fw_version, "%c%d%d.%d%d",
> > 			 adapter->product_info.fw_version[2],
> > 			 adapter->product_info.fw_version[1] >> 8,
> > 			 adapter->product_info.fw_version[1] & 0x0f,
> > 			 adapter->product_info.fw_version[0] >> 8,
> > 			 adapter->product_info.fw_version[0] & 0x0f);
> > 		sprintf (adapter->bios_version, "%c%d%d.%d%d",
> > 			 adapter->product_info.bios_version[2],
> > 			 adapter->product_info.bios_version[1] >> 8,
> > 			 adapter->product_info.bios_version[1] & 0x0f,
> > 			 adapter->product_info.bios_version[0] >> 8,
> > 			 adapter->product_info.bios_version[0] & 0x0f);
> > 	} else {

> > Are the fw_version and bios_version fields more than 8 bits each for HP subsys VID
> > products?  Do HP VID products need a different struct so that they print this info
> > correctly?

Since both are claimed to be strings, I really suspect that this >> 8 is
misspelled >> 4 and they have a character followed by pair of two-digit
packed decimals in there...
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux