ping??
On Sat, 13 Feb 2010 21:23:04 -0800 Randy Dunlap wrote:
> Hi,
>
> sparse produces these warnings:
>
> drivers/scsi/megaraid.c:307:65: warning: right shift by bigger than source value
> drivers/scsi/megaraid.c:309:65: warning: right shift by bigger than source value
> drivers/scsi/megaraid.c:313:67: warning: right shift by bigger than source value
> drivers/scsi/megaraid.c:315:67: warning: right shift by bigger than source value
>
> on this source code:
>
> /* use HP firmware and bios version encoding */
> if (adapter->product_info.subsysvid == HP_SUBSYS_VID) {
> sprintf (adapter->fw_version, "%c%d%d.%d%d",
> adapter->product_info.fw_version[2],
> adapter->product_info.fw_version[1] >> 8,
> adapter->product_info.fw_version[1] & 0x0f,
> adapter->product_info.fw_version[0] >> 8,
> adapter->product_info.fw_version[0] & 0x0f);
> sprintf (adapter->bios_version, "%c%d%d.%d%d",
> adapter->product_info.bios_version[2],
> adapter->product_info.bios_version[1] >> 8,
> adapter->product_info.bios_version[1] & 0x0f,
> adapter->product_info.bios_version[0] >> 8,
> adapter->product_info.bios_version[0] & 0x0f);
> } else {
>
>
> Are the fw_version and bios_version fields more than 8 bits each for HP subsys VID
> products? Do HP VID products need a different struct so that they print this info
> correctly?
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
