From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> Fix sparse warning, which indicates a precedence problem and the data value always being 0: drivers/scsi/qla4xxx/ql4_mbx.c:470:66: warning: right shift by bigger than source value Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> Cc: David C Somayajulu <david.somayajulu@xxxxxxxxxx> Cc: Karen Higgins <karen.higgins@xxxxxxxxxx> Cc: Ravi Anand <ravi.anand@xxxxxxxxxx> Cc: Vikas Chaudhary <vikas.chaudhary@xxxxxxxxxx> --- Sorry if you already received this patch; I thought that I had already sent it, but I can't find it anywhere. And how about a MAINTAINERS entry for qla4xxx, please? drivers/scsi/qla4xxx/ql4_mbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.33-git7.orig/drivers/scsi/qla4xxx/ql4_mbx.c +++ linux-2.6.33-git7/drivers/scsi/qla4xxx/ql4_mbx.c @@ -467,7 +467,7 @@ int qla4xxx_get_fwddb_entry(struct scsi_ if (conn_err_detail) *conn_err_detail = mbox_sts[5]; if (tcp_source_port_num) - *tcp_source_port_num = (uint16_t) mbox_sts[6] >> 16; + *tcp_source_port_num = (uint16_t) (mbox_sts[6] >> 16); if (connection_id) *connection_id = (uint16_t) mbox_sts[6] & 0x00FF; status = QLA_SUCCESS; -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html