On Tue, Mar 02, 2010 at 08:21:41AM -0500, Martin K. Petersen wrote: > >>>>> "Martin" == Martin K Petersen <martin.petersen@xxxxxxxxxx> writes: > > Actually, looking closer at the VPD mechanism in e3deec09 we need to fit > the page header as well... These aren't the only two bugs introduced either. If a device has more VPD pages than the length of the buffer that the caller has allocated, we will now incorrectly report that the device doesn't support that page. James, was any problem actually observed that led to e3deec09? I really think you should revert it. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html