On Tue, 2009-11-03 at 23:55 +0100, Roel Kluin wrote: > Same oddness, are there parentheses missing here? > > Thanks, Roel > > diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c > index 9a42734..25e6d63 100644 > --- a/drivers/scsi/tmscsim.c > +++ b/drivers/scsi/tmscsim.c > @@ -2408,8 +2408,8 @@ static void __devinit dc390_init_hw(struct dc390_acb *pACB, u8 index) > > /* Negation */ > DC390_write8(CtrlReg4, pACB->glitch_cfg | /* glitch eater */ > - (dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ? > - NEGATE_REQACKDATA : 0); > + ((dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ? > + NEGATE_REQACKDATA : 0)); This one looks more possible ... but given it's hw init, the original meaning is also possible ... and supported by the fact that the hw works. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
