On Tue, 2009-11-03 at 23:38 +0100, Roel Kluin wrote: > This looks odd, are there maybe parentheses missing here? > > Thanks, Roel > > diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c > index 8dfb59d..e6aad3e 100644 > --- a/drivers/scsi/aic7xxx/aic7xxx_core.c > +++ b/drivers/scsi/aic7xxx/aic7xxx_core.c > @@ -5534,8 +5534,8 @@ ahc_init(struct ahc_softc *ahc) > * so the format is different. > */ > scsirate = (scsirate & SXFR) >> 4 > - | (ultraenb & mask) > - ? 0x08 : 0x0 > + | ((ultraenb & mask) > + ? 0x08 : 0x0) I really don't think so. The top 4 bits of the scsirate registers are supposed to be transfer features; it would make no sense to be transferring them to the bottom 4 bits and oring in an extra flag. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
