On Sat, 5 Sep 2009 11:34:40 +0200 Bart Van Assche <bart.vanassche@xxxxxxxxx> wrote: > On Sat, Sep 5, 2009 at 11:20 AM, FUJITA Tomonori > <fujita.tomonori@xxxxxxxxxxxxx> wrote: > > > > On Sun, 30 Aug 2009 12:36:48 +0200 > > Bart Van Assche <bart.vanassche@xxxxxxxxx> wrote: > > > > > This patch fixes a memory leak in the libsrp function srp_ring_free(). > > > It is not documented whether or not this function should free the ring > > > pointer itself. But the source code of the callers of this function > > > (srp_target_alloc() and srp_target_free()) makes it clear that > > > srp_ring_free() should deallocate the ring pointer itself. Furthermore, > > > the patch below makes srp_ring_free() deallocate all memory allocated by > > > srp_ring_alloc(). > > > > > > This patch affects the ibmvstgt driver, which is the only in-tree driver > > > that calls the srp_ring_free() function (indirectly). > > > > > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxx> > > > Cc: James Bottomley <James.Bottomley@xxxxxxx> > > > Cc: FUJITA Tomonori <tomof@xxxxxxx> > > > > Acked-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > > > > Better to add: > > > > Cc: stable@xxxxxxxxxx > > Thanks for the review. I will submit this patch to stable@xxxxxxxxxx > as soon as it has been committed. Patches are only accepted for > backporting after they have been committed in the mainline kernel. You don't need to submit a patch to stable@xxxxxxxxxx if you put 'Cc: stable@xxxxxxxxxx' tag in a commit log; the patch will be sent to stable@xxxxxxxxxx automatically after the the patch is merged into mainline. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
