Re: [PATCH 2.6.30] libsrp: fix memory leak in srp_ring_free()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 30 Aug 2009 12:36:48 +0200
Bart Van Assche <bart.vanassche@xxxxxxxxx> wrote:

> This patch fixes a memory leak in the libsrp function srp_ring_free().
> It is not documented whether or not this function should free the ring
> pointer itself. But the source code of the callers of this function
> (srp_target_alloc() and srp_target_free()) makes it clear that
> srp_ring_free() should deallocate the ring pointer itself. Furthermore,
> the patch below makes srp_ring_free() deallocate all memory allocated by
> srp_ring_alloc().
> 
> This patch affects the ibmvstgt driver, which is the only in-tree driver
> that calls the srp_ring_free() function (indirectly).
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxx>
> Cc: James Bottomley <James.Bottomley@xxxxxxx>
> Cc: FUJITA Tomonori <tomof@xxxxxxx>

Acked-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>

Better to add:

Cc: stable@xxxxxxxxxx


Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux