Re: [PATCH] Revert "block: WARN in __blk_put_request() for potential bio leak"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 10 Jun 2009 12:48:01 +0300
Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:

> > BTW, if you try to find a bio leak in the BSG SMP path, I guess that
> > it's worth looking at the bounce path. There might be a leak.
> 
> once a request was put on the queue, or even before that, once some
> memory was mapped. blk_end_request must be called by someone.
> More and more code relays on that. Not doing so is just plain playing
> with fire. Will you not agree?

As I said, I'll fix SMP BSG path to call blk_end_request_all().

IMO, the block layer API is vague before Tejun's recent
cleanups. Seems that everyone uses it (and its internal) in their own
ways. But now we should use it in the consistent way.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux