On Wed, 2009-05-06 at 22:39 -0500, Mike Christie wrote: > Chandra Seetharaman wrote: > > } > > > > -static int rdac_activate(struct scsi_device *sdev, activate_complete fn, void *data) > > +static int queue_mode_select(struct scsi_device *sdev, > > + activate_complete fn, void *data) > > +{ > > + struct rdac_queue_data *qdata; > > + struct rdac_controller *ctlr; > > + > > + qdata = kzalloc(sizeof(*qdata), GFP_KERNEL); > > > I think you want to use GFP_NOIO or GFP_ATOMIC here. If GFP_NOIO can > block and screw up other devices using that multipathd workqueue struct > maybe GFP_ATOMIC would be best since we can have dm-mpath retry later. Will do. Thanks > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html