Re: [PATCH 4/4] sd: misc checkpatch.pl fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-04-29 at 22:09 +0200, Bartlomiej Zolnierkiewicz wrote:
> Fix
> 
> 	ERROR: trailing whitespace
> 	ERROR: code indent should use tabs where possible
> 	WARNING: line over 80 characters
> 	WARNING: braces {} are not necessary for single statement blocks
> 	ERROR: switch and case should be at the same indent
> 	ERROR: space required before the open parenthesis '('
> 
> issues detected by checkpatch.pl.
> 
> While at it:
> - remove superfluous 'ret' local variable in sd_compat_ioctl()

I'd really rather not encourage pure whitespace fixing patches in
SCSI ... we already know there's a lot of non conforming problems from a
crufty code base ... at one patch per file it would take about 500
patches and several thousand lines of review.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux