Jens Axboe wrote: >> So current (above) code in osd_initiator.c is correct and should stay >> as it is? that's fine by me. > > It's still not pretty, any reason you can't just use blk_end_request()? > Why do you need to unroll the bios manually? > I have stared at blk_end_request() multiple times, and I'm afraid to call it it does to many things. accounting, end_that_request_last, lots of not needed stuff. This is a request that was never on any submission Q, it is scary. Also I'm not sure what is the request state it can be very partially built at this stage. But mainly I do not want that bio->bi_end_io(bio, error); will be called. I don't want any read bouncing to happen, just return them to free store. I will try the blk_end_request(,-EIO) and see if it works for all cases Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
