On Fri, 2009-03-13 at 19:19 -0600, Matthew Wilcox wrote: > On Fri, Mar 13, 2009 at 04:29:36PM -0500, James Bottomley wrote: > > On Thu, 2009-03-12 at 14:20 -0400, Matthew Wilcox wrote: > > > +#define RC16_LEN 13 > > > > Shouldn't this be 32, the defined length of a READ CAPACITY 16 return? > > > > In theory asking for less is fine, since the spec allows it, but it's > > setting a trap for expanded users of READ_CAPACITY 16 since they might > > blindly use a buffer[13] or beyond, not realising we didn't actually ask > > for data beyond buffer[12]. > > I'm perfectly fine with expanding it to 16 or even 32. Want me to > repost the patch, or will you fix it up? It's a one liner ... I can do it (crosses fingers). James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
