>>>>> "James" == James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> writes: James> On Thu, 2009-03-12 at 14:20 -0400, Matthew Wilcox wrote: >> +#define RC16_LEN 13 James> Shouldn't this be 32, the defined length of a READ CAPACITY 16 James> return? James> In theory asking for less is fine, since the spec allows it, but James> it's setting a trap for expanded users of READ_CAPACITY 16 since James> they might blindly use a buffer[13] or beyond, not realising we James> didn't actually ask for data beyond buffer[12]. I have this bumped to 16 in my tree (after being bitten by what you describe). I'm open to upping it further even if none of the remaining 16 bytes have been defined yet. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
