> -----Original Message----- > From: linux-scsi-owner@xxxxxxxxxxxxxxx > [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Mike Christie > Sent: Thursday, March 12, 2009 1:44 PM > To: Abhijeet Arvind Joglekar (abjoglek) > Cc: james.bottomley@xxxxxxxxxxxxxxxxxxxxx; > linux-scsi@xxxxxxxxxxxxxxx; Joe Eykholt (jeykholt) > Subject: Re: [RFC][PATCH 5/6] fnic: add descriptor right, > buffers, device interface > > Abhijeet Joglekar wrote: > > diff --git a/drivers/scsi/fnic/vnic_cq.h > b/drivers/scsi/fnic/vnic_cq.h > > new file mode 100644 index 0000000..4ede680 > > --- /dev/null > > +++ b/drivers/scsi/fnic/vnic_cq.h > > > > + > > +/* > > + * These defines avoid symbol clash between fnic and enic > (Cisco 10G Eth > > + * Driver) when both are built with CONFIG options =y > > + */ > > +#define vnic_cq_service fnic_cq_service > > +#define vnic_cq_free fnic_cq_free > > +#define vnic_cq_alloc fnic_cq_alloc > > +#define vnic_cq_init fnic_cq_init > > +#define vnic_cq_clean fnic_cq_clean > > + > > Are these functions implementations the same as the net ones? I only > looked at the first one and it looked the same. Yes, they are the same, it is the low-level queue/buffer code that we wanted to share across enic and fnic. We did consider making a new module out of it, but its not a lot of code, and there was the problem of where the common files will reside, and how we share it across the net and scsi subsystems. So, the plan was to re-define them for fnic (since enic is already integrated) and then go with what the kernel community thinks the best way is. Thanks for the review -- abhijeet > If you are going to share code then you probably want to put > them in a > new module that both enic and fnic can use. > > Are you going to ask where the module should then live > (drivers/net vs > driver/scsi)? I do not know the answer. > -- > To unsubscribe from this list: send the line "unsubscribe > linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
