On Tue, Mar 10, 2009 at 10:25:44PM -0500, Mike Christie wrote: > atomic_set(&hba->state, SOME_STATE_VALUE); > > in a interrupt or thread or tasklet then in another thread they will do > > if (atomic_read(&hba->state) == SOME_STATE_VALUE)) > > Does this mean that the drivers should be doing a > > atomic_set(&hba->state, SOME_STATE_VALUE); > smp_mb(); Possibly "smp_mb__after_atomic_inc()" might be correct. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html