On Tue, 2009-03-03 at 22:08 -0700, Eric Moore wrote: > +/* base shared API */ > +extern struct list_head ioc_list; > + > +int base_attach(struct MPT2SAS_ADAPTER *ioc); > +void base_detach(struct MPT2SAS_ADAPTER *ioc); This is rather generic to be in the global namespace. > +/* config shared API */ > +void config_done(struct MPT2SAS_ADAPTER *ioc, u16 smid, u8 VF_ID, u32 > reply); And this. > +void ctl_init(void); > +void ctl_exit(void); > +void ctl_done(struct MPT2SAS_ADAPTER *ioc, u16 smid, u8 VF_ID, u32 > reply); Ditto this. Would it not be better to have a mpt2sas_ prefix added to all the non-static symbols? James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
