Maybe double check whether something else is missing instead? Otherwise feel free to ignore. --------------------------->8-------------8<------------------------------ code_set == 1 is tested twice. Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> --- diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c index e946e05..a3da4ce 100644 --- a/drivers/scsi/ses.c +++ b/drivers/scsi/ses.c @@ -393,7 +393,7 @@ static void ses_match_to_enclosure(struct enclosure_device *edev, u8 type = desc[1] & 0x0f; u8 len = desc[3]; - if (piv && code_set == 1 && assoc == 1 && code_set == 1 + if (piv && code_set == 1 && assoc == 1 && proto == SCSI_PROTOCOL_SAS && type == 3 && len == 8) efd.addr = (u64)desc[4] << 56 | (u64)desc[5] << 48 | -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html