Ulrich Windl wrote: > On 12 Jan 2009 at 17:33, Boaz Harrosh wrote: > >> --- a/drivers/scsi/iscsi_tcp.h >> +++ b/drivers/scsi/iscsi_tcp.h >> @@ -25,6 +25,12 @@ >> #include <scsi/libiscsi.h> >> #include <scsi/libiscsi_tcp.h> >> >> +#if (CONFIG_ISCSI_DEBUG & 2) >> +#define debug_tcp(fmt...) printk(KERN_INFO "tcp: " fmt) >> +#else >> +#define debug_tcp(fmt...) >> +#endif >> + > > Hi! > > Let me say that I feel that "tcp:" should be something like "iSCSI-TCP:", just to > point out that it's related to iSCSI. > > Regards, > Ulrich > > This is unrelated to this patch. If so, it should be in another, additional patch. I think we don't need to bother because these are in headers private to iscsi and should never be included by any other code. But Mike if you want I can send search-replace patch for debug_tcp/debug_scsi macros. What do you prefer? Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
