Boaz Harrosh wrote: > > Remove the dark ages /* define debug_print */ in code, to use > a Kconfig option. With a system like Kconfig, in code, commented out, > configuration options are slavery and hard work. > (version control, manual edit ... need I say more) > > I've used an "int" config bit-mask so more areas of code can be > selected with one Koption, but mainly so that allmodconfig will > not turn it on. > > bit-1 - will turn on prints for libiscsi. > bit-2 - will turn on prints for libiscsi_tcp & iscsi_tcp. > > More iscsi drivers should use more bits. > > Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx> > --- > drivers/scsi/Kconfig | 15 +++++++++++++++ > drivers/scsi/iscsi_tcp.c | 7 ------- > drivers/scsi/iscsi_tcp.h | 6 ++++++ > drivers/scsi/libiscsi_tcp.c | 7 ------- > include/scsi/libiscsi.h | 3 +-- > 5 files changed, 22 insertions(+), 16 deletions(-) > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig Mike hi. These are over latest Linus. Sorry I mixed up the branches. If they don't apply to your tree any more, I'll rebase. I'm sending these because for too many times I submit some code with iscsi sources edits, because I forget to remove the edits for enabling prints. Please consider for inclusion. Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
