[PATCH] qla2xxx: Fix for incorrect unconditionally interrupts enabling on IRQ context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



A rather trivial patch. Function qla2x00_schedule_rport_del() can be called on IRQ
context, so it can't unconditionally enable interrupts. Spotted by lockdep.

This patch is against 2.6.27.2, but applies also on 2.6.28-rc7.

Signed-off-by: Vladislav Bolkhovitin <vst@xxxxxxxx>
	
 qla_os.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff -upr linux-2.6.27.2/drivers/scsi/qla2xxx/qla_os.c linux-2.6.27.2/drivers/scsi/qla2xxx/qla_os.c
--- linux-2.6.27.2/drivers/scsi/qla2xxx/qla_os.c	2008-10-21 13:57:15.000000000 +0400
+++ linux-2.6.27.2/drivers/scsi/qla2xxx/qla_os.c	2008-12-05 11:14:21.000000000 +0300
@@ -1862,9 +1885,10 @@ qla2x00_schedule_rport_del(struct scsi_q
 
 	rport = fcport->rport;
 	if (defer) {
-		spin_lock_irq(ha->host->host_lock);
+		unsigned long flags;
+		spin_lock_irqsave(ha->host->host_lock, flags);
 		fcport->drport = rport;
-		spin_unlock_irq(ha->host->host_lock);
+		spin_unlock_irqrestore(ha->host->host_lock, flags);
 		set_bit(FCPORT_UPDATE_NEEDED, &pha->dpc_flags);
 		qla2xxx_wake_dpc(pha);
 	} else

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux