> Yeah, I know. It's not nice (as I wrote in the first mail), it doesn't > work well, etc. But it's not the point (as I wrote in the previous > mail). I'm against the patch just because I don't think the rules > about the userspace API permit removing the exiting API like this. Ok perhaps removing the define was a bit much, but at least stubbing the ioctl should be transparent to the application. Ok except that I return EINVAL in the set variant now. I could lie and return 0 instead, although I suspect it wouldn't make much difference either way. > > If the rules permit, I'm happy to try to remove more old features of > sg. As long as old binaries don't break I don't see a problem with any such changes (afaik that's true for my change) If you want to break something you have to just go through feature deprecation and printk, but normally it's only a good idea to do that if it saves a lot of code or ugliness. -Andi -- ak@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
