On Mon, 17 Nov 2008 12:23:46 +0100 Andi Kleen <andi@xxxxxxxxxxxxxx> wrote: > > > I would rather prefer to fix the driver to always GFP_DMA, but I am > > > not aware of any driver who needs it. Are you? > > > > Well, theoretically, there migth be an user who want these ioctl with > > all the drivers that are not capable of 64bit DMA since sg allocates > > the reserved buffer with GFP_KERNEL. These driver might use the > > block-layer bounce buffer. Users might want to use > > SG_SET_FORCE_LOW_DMA to avoid the bounce buffer latency. > > But that would force everything through the 16MB zone, > putting a lot of pressure on it and might even overflow on some > loads. I don't think that's a good strategy for any application. Yeah, I know. It's not nice (as I wrote in the first mail), it doesn't work well, etc. But it's not the point (as I wrote in the previous mail). I'm against the patch just because I don't think the rules about the userspace API permit removing the exiting API like this. If the rules permit, I'm happy to try to remove more old features of sg. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
