On Mon, 2008-10-13 at 13:41 -0400, Levy_Jerome@xxxxxxx wrote:
> Patch to fix intermittent but frequent oops occurring with multiple
> paths to Clariion at boot.
> Cause is uninitialized rq->flags variable which presents garbage from
> clariion_activate.
There are several syntactic problems with the patch: It's against a
pretty old kernel (cmd has been a pointer for a while, so the memset
went away). It's also whitespace damaged (all tabs have become spaces).
However, I also don't quite understand why this is necessary. All calls
to blk_get_request() ultimately end up in blk_rq_init() which does a
memset(rq, 0, sizeof(*rq)) which should clear flags. How is it getting
bogus data?
James
> Signed-off-by: Jerry Levy <levy_jerome@xxxxxxx>
> ---------------------
> --- drivers/scsi/device_handler/scsi_dh_emc.orig 2008-10-13
> 13:33:35.000000000 -0400
> +++ drivers/scsi/device_handler/scsi_dh_emc.c 2008-10-09
> 16:20:15.000000000 -0400
> @@ -283,6 +283,7 @@
> memset(rq->cmd, 0, BLK_MAX_CDB);
> rq->cmd[0] = cmd;
> rq->cmd_len = COMMAND_SIZE(cmd);
> + rq->flags = 0;
>
> switch (cmd) {
> case MODE_SELECT:
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
