Abhijit - You're patch would allow page 0x19 to STP devices, which I doubt is supported either. I think you should be doing the following instead:
+ if (rphy->identify.device_type == SAS_END_DEVICE &&
+ (rphy->identify.target_port_protocols & SAS_PROTOCOL_SSP))
+ sas_read_port_mode_page(sdev);
________________________________________
From: linux-scsi-owner@xxxxxxxxxxxxxxx [linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Abhijit Paithankar [apaithan@xxxxxxxxxx]
Sent: Monday, October 13, 2008 6:40 PM
To: Prakash, Sathya
Cc: Douglas Gilbert; linux-scsi@xxxxxxxxxxxxxxx; Moore, Eric
Subject: Re: LSISAS1068 ioerr_cnt 0x1 on clean boot up
Hi Sathya,
* Prakash, Sathya (Sathya.Prakash@xxxxxxx) wrote:
> I found the reason for the non zero err_cnt for SATA drives attached to mptsas.
> It is due to the failure in sending mode sense request for page 0x19 from mptsas driver for SATA drives (which is not supported by MPTSAS controller).
>
> In the slave_configure function of mptsas driver, the transport layer function sas_read_port_mode_page is called for all the devices attached with the MPTSAS controller. Since it is that particular mode page is not supported for SATA drives, Check condition with Skey=Invalid request and ASC=Invalid field in CDB is returned. Hence the error count is incremented by the scsi_done.
>
> If it needs to be fixed, then we need to provide a patch in mptsas driver so that it will not call sas_read_port_mode_page for SATA devices.
Thanks for your efforts!
I patched the kernel with the following code and it is still showing a
non-zero ioerr_cnt.
Either my patch is wrong or this was just one of the issues.
Thanks!
Abhijit
Signed-off-by: Abhijit Paithankar <apaithan@xxxxxxxxxx>
Index: linux-2.6.27/drivers/message/fusion/mptsas.c
===================================================================
--- linux-2.6.27.orig/drivers/message/fusion/mptsas.c 2008-10-13 17:31:57.000000000 -0700
+++ linux-2.6.27/drivers/message/fusion/mptsas.c 2008-10-13 17:33:25.000000000 -0700
@@ -839,11 +839,15 @@ mptsas_sas_enclosure_pg0(MPT_ADAPTER *io
static int
mptsas_slave_configure(struct scsi_device *sdev)
{
+ struct sas_rphy *rphy;
if (sdev->channel == MPTSAS_RAID_CHANNEL)
goto out;
- sas_read_port_mode_page(sdev);
+ rphy = dev_to_rphy(sdev->sdev_target->dev.parent);
+ if (rphy->identify.device_type == SAS_END_DEVICE &&
+ !(rphy->identify.target_port_protocols & SAS_PROTOCOL_SATA))
+ sas_read_port_mode_page(sdev);
out:
return mptscsih_slave_configure(sdev);
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
