On Mon, 13 Oct 2008, James Bottomley wrote: > > This represents all the pieces of SCSI which were depending on the > already merged block tree. Grr. And it doesn't actually compile. drivers/scsi/sd.c:579:27: error: macro "sd_dif_op" passed 4 arguments, but takes just 3 drivers/scsi/sd.c: In function ʽsd_prep_fnʼ: drivers/scsi/sd.c:578: error: ʽsd_dif_opʼ undeclared (first use in this function) drivers/scsi/sd.c:578: error: (Each undeclared identifier is reported only once drivers/scsi/sd.c:578: error: for each function it appears in.) Hmm? Was this testedt AT ALL? It can never compile unless that idiotic CONFIG_BLK_DEV_INTEGRITY option is set that no sane person would set right now, and which is even documented to not be enabled by default: If in doubt, say N. yet it looks like it has not compiled since a commit that was put in in the middle of September! What part of "This is total untested crap" are we missing here? Yeah, I'm grumpy. I expect to not be fed shit like this. It has apparently been rebased several times, and all apparently with no testing what-so-ever! Linus -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
