Re: [PATCH] sd: remove command-size switching code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 10, 2008 at 04:03:20PM -0400, Alan Stern wrote:
> This patch (as1138) removes from sd.c some old code for switching from
> 10-byte commands to 6-byte commands.  This code is redundant -- the
> switching for READ and WRITE is already handled in
> scsi_io_completion() and the switching for MODE SENSE is already
> handled in scsi_mode_sense().  (There is no comparable switch for MODE
> SELECT, but I doubt one is needed.)

I noticed this odd duplication a few months ago and meant to ask about
it then, but forgot.  Thanks for cleaning this up.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux