Re: [lm-sensors] [PATCH 08/12] i5k_amb: Load automatically on all 5000/5400 chipsets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Darrick,

On Mon, 06 Oct 2008 18:19:04 -0700, Darrick J. Wong wrote:
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
> 
>  drivers/hwmon/i5k_amb.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/i5k_amb.c b/drivers/hwmon/i5k_amb.c
> index 2ede938..bf153ae 100644
> --- a/drivers/hwmon/i5k_amb.c
> +++ b/drivers/hwmon/i5k_amb.c
> @@ -605,3 +605,6 @@ MODULE_LICENSE("GPL");
>  
>  module_init(i5k_amb_init);
>  module_exit(i5k_amb_exit);
> +
> +MODULE_ALIAS("pci:v00008086d000025F0sv*sd*bc*sc*i*");
> +MODULE_ALIAS("pci:v00008086d00004030sv*sd*bc*sc*i*");

This looks wrong to me. If these PCI devices provide the feature this
driver supports, then why is this a platform driver and not a PCI
driver? You would get the right module aliases for free.


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux