On Tue, 30 Sep 2008, James Bottomley wrote: > However, there's a slight problem in that some senses need to be > interpreted differently depending on what the ULD is which leads to the > current 3 tier system (before in decide disposition, during in ULD done > and after in scsi_io_completion). > > The discriminators in the done functions do look to be duplicates, so I > suppose they could be collapsed. Related to this in a minor way is my patch from September 25, which removes from sd_done() the code to update the use_10_for_rw and use_10_for_ms flags: http://marc.info/?l=linux-scsi&m=122236940613587&w=2 This change has now been confirmed to fix a problem that previously caused a disk drive to be unusable: https://lists.one-eyed-alien.net/pipermail/usb-storage/2008-September/004022.html Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
