The reason we creating our own sysfs directory under /sys/devices path was we felt the fc transport and scsi host attributes are not enough for all the HBA management features we want to have. We have ioctl in our non opensource driver, and we want to have something to emulate all/most of the IOCTL functionality we have in the opensource driver. We provide multi-level of driver/fw statistics info to the user, and we want to put those info under a separate directory instead of throw them all under scsi_host. I just didn't know how to create a subdirectory under scsi/fc host. Currently, we only implement a small portion of all the IOCTL functionalities. We want to know if this is acceptable in the upstream kernel. I agree that there are a lot of redundancy with the attributes we created under scsi_host. We will clean them up. Jing -----Original Message----- From: Greg KH [mailto:greg@xxxxxxxxx] Sent: Thursday, September 25, 2008 7:55 PM To: Jing Huang Cc: James.Bottomley@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; Ramkumar Vadivelu; Srikanth Rayas (CW); Vinodh Ravindran Subject: Re: [PATCH 5/6] bfa: Brocade BFA FC SCSI driver submission (2ndtry) On Thu, Sep 25, 2008 at 06:06:00PM -0700, Jing Huang wrote: > From: Jing Huang <huangj@xxxxxxxxxxx> > > This patch contains document of brocade specific sysfs interface. > It is created using 2.6.27-rc7 kernel. What about my question for the need for all of these files and using debugfs instead? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
