James,
I haven't seem any comment on this patch to fix sd's NO_SENSE handling.
Can it go into scsi-post-merge-2.6?
Thanks,
Jamie
On Thu, 2008-09-11 at 18:39 -0700, Wellnitz, Jamie wrote:
> The current handling of NO_SENSE check condition is the same as
> RECOVERED_ERROR, and assumes that in both cases, the I/O was fully
> transferred.
>
> We have seen cases of arrays returning with NO_SENSE (no error), but
> the I/O was not completely transferred, thus residual set. Thus,
> rather than return good_bytes as the entire transfer, set good_bytes
> to 0, so that the midlayer then applies the residual in calculating
> the transfer, and for sd, will fail the I/O and fall into a retry
> path.
>
> Signed-off-by: Jamie Wellnitz <Jamie.Wellnitz@xxxxxxxxxx>
> ---
> drivers/scsi/sd.c | 10 +++++++++-
> 1 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index af9e406..2a5fe5e 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -1048,7 +1048,6 @@ static int sd_done(struct scsi_cmnd *SCpnt)
> good_bytes = sd_completed_bytes(SCpnt);
> break;
> case RECOVERED_ERROR:
> - case NO_SENSE:
> /* Inform the user, but make sure that it's not treated
> * as a hard error.
> */
> @@ -1057,6 +1056,15 @@ static int sd_done(struct scsi_cmnd *SCpnt)
> memset(SCpnt->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE);
> good_bytes = scsi_bufflen(SCpnt);
> break;
> + case NO_SENSE:
> + /* This indicates a false check condition, so ignore it. An
> + * unknown amount of data was transferred so treat it as an
> + * error.
> + */
> + scsi_print_sense("sd", SCpnt);
> + SCpnt->result = 0;
> + memset(SCpnt->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE);
> + break;
> case ABORTED_COMMAND:
> if (sshdr.asc == 0x10) { /* DIF: Disk detected corruption */
> scsi_print_result(SCpnt);
> --
> 1.6.0.1.308.gede4c
>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
