From: Boaz Harrosh <bharrosh@xxxxxxxxxxx>
Date: Wed, 24 Sep 2008 12:00:22 +0300
> Subject: [PATCH] fix fall out of sg-chaining patch
>
> I've reviewed all patches since Matthew's, and I find one small
> problem.
>
> In the load_cmd() there is a compound loop where the first 4 sg's are
> set then the rest are set into a memory structure in group of 7 sg's.
>
> Well the second 7-group and on is a bug because sg pointer does not advance.
> This is a fall out from Jens's patch.
>
> I'm not sure if this is it but it should be fixed
Definitely a bug, and I looked at the patch that addded this code,
specifically audited this stuff, and didn't notice the problem. :-)
Meelis, see if this patch helps out your case, thanks!
> ---
> git diff --stat -p
> drivers/scsi/qlogicpti.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
> index 4a1cf63..9053508 100644
> --- a/drivers/scsi/qlogicpti.c
> +++ b/drivers/scsi/qlogicpti.c
> @@ -914,6 +914,7 @@ static inline int load_cmd(struct scsi_cmnd *Cmnd, struct Command_Entry *cmd,
> ds[i].d_count = sg_dma_len(s);
> }
> sg_count -= n;
> + sg = s;
> }
> } else {
> cmd->dataseg[0].d_base = 0;
> --
> To unsubscribe from this list: send the line "unsubscribe sparclinux" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
