Re: [PATCH 6/9] lpfc: start to use new trasnport errors.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mike,

This patch was superceeded by a change in our 8.2.8 patch set.
See: http://marc.info/?l=linux-scsi&m=121962902831367&w=2

thanks

-- james s

michaelc@xxxxxxxxxxx wrote:
From: Mike Christie <michaelc@xxxxxxxxxxx>

This patch converts lpfc to use DID_TRANSPORT_DISRUPTED. I did not
do the queuecommand conversion of DID_BUS_BUSY because the
SCSI_MLQUEUE_TARGET_BUSY patches convert that.

Patch was tested with a direct connection by unplugging cables.
I did not hit the port of fabric busy paths, but saw that a distro
lpfc driver converted that bus busy to DID_TRANSPORT_DISRUPTED.
Also it looks like qla2xxx blocks the rport for that case.

Signed-off-by: Mike Christie <michaelc@xxxxxxxxxxx>
---
 drivers/scsi/lpfc/lpfc_scsi.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index 1bcebbd..3678adf 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -570,7 +570,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn,
                        break;
                case IOSTAT_NPORT_BSY:
                case IOSTAT_FABRIC_BSY:
-                       cmd->result = ScsiResult(DID_BUS_BUSY, 0);
+                       cmd->result = ScsiResult(DID_TRANSPORT_DISRUPTED, 0);
                        break;
                case IOSTAT_LOCAL_REJECT:
                        if (lpfc_cmd->result == RJT_UNAVAIL_PERM ||
@@ -586,7 +586,14 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn,

                if (!pnode || !NLP_CHK_NODE_ACT(pnode)
                    || (pnode->nlp_state != NLP_STE_MAPPED_NODE))
-                       cmd->result = ScsiResult(DID_BUS_BUSY, SAM_STAT_BUSY);
+                       /*
+                        * Port is not setup so fail IO with
+                        * DID_TRANSPORT_DISRUPTED, and allow the fc
+                        * class to determine what to do with it when
+                        * its timers fire.
+                        */
+                       cmd->result = ScsiResult(DID_TRANSPORT_DISRUPTED,
+                                                SAM_STAT_BUSY);
        } else {
                cmd->result = ScsiResult(DID_OK, 0);
        }
--
1.5.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux