Actually, I'm about to post another set of patches, and this fix is
included. So pick it up there...
-- james s
Smart, James wrote:
Acked-by: James Smart <james.smart@xxxxxxxxxx>
-- james s
Benny Halevy wrote:
gcc 4.3.0 prints this warning:
drivers/scsi/lpfc/lpfc_scsi.c: In function ‘lpfc_bus_reset_handler’:
drivers/scsi/lpfc/lpfc_scsi.c:1245:\
warning: ‘status’ may be used uninitialized in this function
It seems like the warning is bogus. However, this patch makes
sure status is always initialized before used.
Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxxx>
---
drivers/scsi/lpfc/lpfc_scsi.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index 1bcebbd..9eda9b2 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -1278,8 +1278,9 @@ lpfc_bus_reset_handler(struct scsi_cmnd *cmnd)
ndlp->rport->dd_data);
if (status != TIMEOUT_ERROR)
lpfc_release_scsi_buf(phba, lpfc_cmd);
- }
- if (!lpfc_cmd || status != SUCCESS) {
+ } else
+ status = FAILED;
+ if (status != SUCCESS) {
lpfc_printf_vlog(vport, KERN_ERR, LOG_FCP,
"0700 Bus Reset on target %d failed\n",
i);
--
1.6.0
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
