On Thu, 14 Aug 2008 15:41:28 -0400 (EDT) Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 13 Aug 2008, Boaz Harrosh wrote: > > > One thing I don't like is the now blk_end_request(req, -EIO, bytes=0) > > inside scsi_end_request(). What's the point of calling that with 0 bytes? > > Maybe fix that too. > > While testing the patch, I learned what the point is. :-) > > Actually it's very simple; you just have to remember that not all > requests are BLOCK_FS type. Other types of request can indeed have a > transfer length of 0, and we want to end those requests normally. > > So this version of the patch works better than the earlier one. In > principle there doesn't seem to be any reason not to call > blk_end_request with bytes = 0, but I left the test in there. > > Alan, you might want to test this version and see how well it works for > you. > > Alan Stern > Thanks Alan, the latest patch fixes the problem for me as well, just great. Now here's the log I have, there are still Medium errors, but I think that's ok, I also had them with 2.6.24 after all. http://shell.studenti.unina.it/~ospite/tmp/linux-usb/usb-mass-storage+Alan_Stern_patch-2.6.27-rc3-WORKING.log Best regards, Antonio Ospite -- A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? Web site: http://www.studenti.unina.it/~ospite Public key: http://www.studenti.unina.it/~ospite/aopubkey.asc
Attachment:
pgpPxmjpkSVLa.pgp
Description: PGP signature
