If an ELS is received while the virtual fibre channel adapter is going through
its discovery, a flag is set which causes discovery to get re-driven. However,
the hosts's state does not get set back to IBMVFC_INITIALIZING and scsi_block_requests
does not get called again, which can result in queuecommand ops getting sent during
discovery. This should not occur and may cause problems. One example is that we
may no longer be logged into the target we send the command to, resulting in a failure
which should not have occurred.
Signed-off-by: Brian King <brking@xxxxxxxxxxxxxxxxxx>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN drivers/scsi/ibmvscsi/ibmvfc.c~ibmvfc_reinit_state_fix drivers/scsi/ibmvscsi/ibmvfc.c
--- linux-2.6/drivers/scsi/ibmvscsi/ibmvfc.c~ibmvfc_reinit_state_fix 2008-08-13 11:12:33.000000000 -0500
+++ linux-2.6-bjking1/drivers/scsi/ibmvscsi/ibmvfc.c 2008-08-13 15:34:20.000000000 -0500
@@ -3602,8 +3602,9 @@ static void ibmvfc_do_work(struct ibmvfc
}
}
- if (vhost->reinit) {
+ if (vhost->reinit && !ibmvfc_set_host_state(vhost, IBMVFC_INITIALIZING)) {
vhost->reinit = 0;
+ scsi_block_requests(vhost->host);
ibmvfc_set_host_action(vhost, IBMVFC_HOST_ACTION_QUERY);
} else {
ibmvfc_set_host_action(vhost, IBMVFC_HOST_ACTION_NONE);
_
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
