ACK. Thanks, Bo Yang -----Original Message----- From: Joe Malicki [mailto:jmalicki@xxxxxxxxxxxxx] Sent: Thursday, August 14, 2008 5:15 PM To: Yang, Bo Cc: linux-scsi@xxxxxxxxxxxxxxx Subject: megaraid_sas dbg_lvl permissions /sys/bus/pci/drivers/megaraid_sas/dbg_lvl defaults to being world-writable, which seems bad (letting any user affect kernel driver behavior and logging level). This turns off group and user write permissions, so that on typical production systems only root can write to it. Signed-off-by: Joseph Malicki <jmalicki@xxxxxxxxxxxxx> -- --- drivers/scsi/megaraid/megaraid_sas.c.orig 2008-01-31 10:49:57.000000000 -0500 +++ drivers/scsi/megaraid/megaraid_sas.c 2008-01-31 10:52:10.000000000 -0500 @@ -3044,7 +3044,7 @@ return retval; } -static DRIVER_ATTR(dbg_lvl, S_IRUGO|S_IWUGO, megasas_sysfs_show_dbg_lvl, +static DRIVER_ATTR(dbg_lvl, S_IRUGO|S_IWUSR, +megasas_sysfs_show_dbg_lvl, megasas_sysfs_set_dbg_lvl); /** -- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
