On Sat, 9 Aug 2008 07:55:21 -0600 Matthew Wilcox <matthew@xxxxxx> wrote: > On Sat, Aug 09, 2008 at 12:09:38PM +0200, Adel Gadllah wrote: > > ------------------------ > > This patch changes the interface of the cmd filter to use a +/- notation like: > > echo -- +0x02 +0x03 -0x08 > > If neither + or - is given it defaults to + (allow command). > > > > Note: The interface was added in 2.6.17-rc1 and is unused > > and undocumented so far so it's safe to change it. > > > > Cc: matthew@xxxxxx > > Cc: fujita.tomonori@xxxxxxxxxxxxx > > Cc: jens.axboe@xxxxxxxxxx > > Cc: James.Bottomley@xxxxxxxxxxxxxxxxxxxxx > > Cc: dan.j.williams@xxxxxxxxx > > Cc: pjones@xxxxxxxxxx > > Cc: viro@xxxxxxxxxxxxxxxxxx > > Cc: dougg@xxxxxxxxxx > > Signed-off-by: Adel Gadllah <adel.gadllah@xxxxxxxxx> > > Reviewed-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx> I am also fine with this version. After using this API a bit, I thought that this interface is a bit unhandy when I just want to set up new access permissions from the scratch though the new interface is handy when I want to modify the current permissions. I guess that in some cases (such as on bootup), we don't care about the current permissions, just want to set up our permissions. It would be nice if we can drop the current permissions (all the commands are prohibited), something like "echo -- > read_table" -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
